Skip to content

[No QA] Docs updates for E/A#76741 Update message editing steps for mobile composer#90568

Open
MelvinBot wants to merge 2 commits into
mainfrom
melvin-docsUpdatesForPR76741
Open

[No QA] Docs updates for E/A#76741 Update message editing steps for mobile composer#90568
MelvinBot wants to merge 2 commits into
mainfrom
melvin-docsUpdatesForPR76741

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Summary

  • Updates the "Edit or Delete Messages" section in Chat-Features-and-Moderation-Tools.md to reflect the new editing behavior introduced in New editing mechanism for small screens #76741
  • On mobile/small screens, editing now uses the bottom composer instead of inline editing
  • Separates desktop and mobile instructions per HelpDot naming conventions (platform-specific flows must be documented separately)

Test plan

  • Verify the updated article renders correctly on the help site
  • Confirm desktop editing steps match current desktop behavior (inline editing)
  • Confirm mobile editing steps match the new bottom-composer behavior

Co-authored-by: Alexey Kureev <Kureev@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label May 13, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#76741 Update message editing steps for mobile composer [No QA] Docs updates for E/A#76741 Update message editing steps for mobile composer May 13, 2026
@OSBotify

This comment has been minimized.

@stephanieelliott stephanieelliott marked this pull request as ready for review May 15, 2026 02:13
@stephanieelliott stephanieelliott self-requested a review as a code owner May 15, 2026 02:13
@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR updates the "Edit or Delete Messages" section in Chat-Features-and-Moderation-Tools.md to separate desktop and mobile instructions, reflecting a behavioral difference where mobile editing now uses the bottom composer instead of inline editing. The change is well-motivated and improves cross-platform clarity. There are a few governance compliance items to address.

Scores Summary

  • Readability: 8/10 - Steps are clear, sequential, and action-oriented. The desktop/mobile split improves scannability. Minor deduction: "the message text appears in the composer at the bottom of the screen" in mobile step 4 is slightly verbose and could be tightened.
  • AI Readiness: 6/10 - The new ## headings are task-based and include "How to," which is good. However, per HELP_AUTHORING_GUIDELINES.md Section 2, headings should not use platform-only labels as differentiators. The headings "How to edit or delete a message on desktop" and "How to edit or delete a message on mobile" use platform labels rather than the exact feature name. They should include the feature context (e.g., "How to edit or delete a chat message on desktop" or similar phrasing that includes the feature name). Additionally, the parent # Edit or Delete Messages heading is not task-based (it is a noun/action phrase without a verb-first or question-word-first structure), though this is pre-existing and not introduced by this PR.
  • Style Compliance: 8/10 - Button names (Edit comment, Delete comment, Enter, Save) are correctly bolded. The desktop/mobile separation follows the Navigation Instruction Standards in HELPSITE_NAMING_CONVENTIONS.md ("If Web and Mobile Navigation Differ: Provide separate instructions"). Minor note: the governance docs use "Web" and "Mobile" as platform labels, while the PR uses "desktop" and "mobile" -- this is acceptable but worth noting for consistency across articles.

Key Findings

  • Positive: Splitting desktop and mobile instructions is the right call per governance rules, since the editing behavior genuinely differs between platforms (inline vs. composer).
  • Positive: Steps are sequential, action-oriented, and aligned with actual UI flow per Section 5 of the authoring guidelines.
  • Improvement needed: The ## headings should ideally include the feature name for better AI retrieval precision (e.g., "How to edit or delete a chat message on desktop" rather than "How to edit or delete a message on desktop").
  • Pre-existing issue (not scored against this PR): The parent # Edit or Delete Messages heading is not task-based per Section 2 rules. The article also lacks an internalScope field in its YAML frontmatter, which is required per Section 3 of the authoring guidelines. These are outside the scope of this PR but worth noting for a future pass.

Recommendations

  1. Consider adding "chat" to the ## headings to include the feature name (e.g., "How to edit or delete a chat message on desktop") for improved search and retrieval precision.
  2. The changes are otherwise solid and align well with governance expectations for cross-platform documentation.

Files Reviewed

  • docs/articles/new-expensify/chat/Chat-Features-and-Moderation-Tools.md - Desktop/mobile instruction split for message editing. Good structural change with minor heading refinement opportunity.

Review based on governance files: HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md.

Comment thread docs/articles/new-expensify/chat/Chat-Features-and-Moderation-Tools.md Outdated
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 79d533184d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@stephanieelliott stephanieelliott self-assigned this May 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR improves the "Edit or Delete Messages" section by splitting a single generic set of steps into platform-specific instructions for desktop and mobile. The change is well-motivated: the interaction patterns genuinely differ between platforms (right-click/hover vs. long-press, inline editing vs. composer-based editing). The new content is clear, accurate, and follows governance conventions with only minor issues.

Scores Summary

  • Readability: 9/10 - Steps are sequential, clear, and action-oriented. The platform split makes the instructions easier to follow. Step 4 in each section uses a conditional ("If editing...") which is acceptable but slightly less scannable than pure imperative steps.
  • AI Readiness: 8/10 - Both new headings are task-based and start with "How to," which is correct per the authoring guidelines. They include the feature action ("edit or delete a message") and the platform context. However, neither heading includes the product name ("New Expensify" or "Expensify"), which would improve semantic retrieval precision. The existing article-level metadata and YAML frontmatter are unchanged and were not part of this PR, so they are not scored here.
  • Style Compliance: 9/10 - UI element references (Edit comment, Delete comment, Enter, Save) are correctly bolded and appear to match product UI text. The platform separation follows the Cross-Platform Clarity Rule and Navigation Instruction Standards from the naming conventions. One minor note: the pre-existing # Edit or Delete Messages heading above these sections is a noun-phrase heading rather than task-based, but since it was not changed in this PR, it is not scored against the diff.

Key Findings

  • The platform-specific split is the right approach. Desktop uses right-click/hover with inline editing; mobile uses long-press with composer-based editing. These are genuinely different UX flows and warrant separate step sequences, consistent with the governance rule: "If Web and Mobile Navigation Differ -- Provide separate instructions."
  • Step 4 in both sections describes the editing save behavior, which is a useful addition that was missing from the original. Users now know exactly how to confirm their edits on each platform.
  • UI labels (Edit comment, Delete comment, Save, Enter) are bolded correctly per Button Naming Standards.

Recommendations

  • Consider adding "in New Expensify" to the two new headings (e.g., "How to edit or delete a message on desktop in New Expensify") to improve AI retrieval specificity. This is a minor suggestion, not a blocker -- the current headings are already task-based and compliant.
  • No blocking issues found. The changes are clean, well-structured, and governance-compliant.

Files Reviewed

  • docs/articles/new-expensify/chat/Chat-Features-and-Moderation-Tools.md -- Platform-specific edit/delete instructions added. Compliant with governance rules. Approved.

Comment thread docs/articles/new-expensify/chat/Chat-Features-and-Moderation-Tools.md Outdated
@OSBotify
Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://8f12c9e2.helpdot.pages.dev ⚡️

Updated articles:

# Edit or Delete Messages

**To edit or delete a message:**
## How to edit or delete a message on web
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heading style: This task-based heading is well-structured (starts with "How to"), but consider including the feature name for better AI retrieval and searchability per HELP_AUTHORING_GUIDELINES.md Section 6 ("Include at least one full 'How to...' heading using feature name").

Suggestion: ## How to edit or delete a chat message on web

This minor addition of "chat" ties the heading to the article's feature name and improves semantic search matching.

@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes targeted improvements to the "Edit or Delete Messages" section of the Chat Features and Moderation Tools article. The changes (1) correct "Desktop" to "Web" for platform labeling consistency, (2) split the edit/delete instructions into separate web and mobile sections with proper ## headings, and (3) add platform-specific detail for step 4 (inline editing on web vs. composer on mobile). These are positive, governance-aligned changes.

Scores Summary

  • Readability: 9/10 - The new platform-split steps are clear, sequential, and action-oriented. Step 4 in each section helpfully describes the distinct editing experience per platform. The parenthetical "(or hover over)" in step 2 of the web section is a nice touch for discoverability.
  • AI Readiness: 8/10 - Both new ## headings follow the "How to..." task-based pattern required by the authoring guidelines and are searchable. Minor deduction: the headings do not include the feature name (e.g., "in New Expensify" or "in New Expensify Chat"), which the guidelines recommend for retrieval precision. The YAML metadata was not modified but remains adequate for the article scope.
  • Style Compliance: 9/10 - Button names (Edit comment, Delete comment, Enter, Save) are correctly bolded and match expected UI labels. The "On Web:" to platform-heading migration follows naming conventions. The platform split follows the governance rule to provide separate instructions when web and mobile differ. Minor note: "web" in the headings is lowercase ("on web"); the existing article uses "On Web:" and "On Mobile:" with capitalization elsewhere -- consistency within the article could be tightened, though governance does not mandate a specific casing for platform references inside headings.

Key Findings

  • The rename from "On Desktop:" to "On Web:" aligns terminology with the rest of the help site and the naming conventions doc, which references "web" as the standard platform label.
  • Splitting edit/delete into two ## headings with platform-specific steps is a direct improvement for both human readers and AI retrieval. Previously, a single bold label ("To edit or delete a message:") served both platforms with no mobile-specific guidance.
  • The new step 4 for each platform adds genuinely useful detail: web editing is inline with Enter to save, while mobile editing uses the composer with a Save button. This cross-platform clarity is exactly what the governance docs call for.
  • Pre-existing issue (not introduced by this PR): The article uses multiple # headings ("Send and Format Messages", "Edit or Delete Messages", "Start a Conversation Thread", etc.), which violates the "exactly one # heading (the article title)" rule in HELP_AUTHORING_GUIDELINES.md Section 4. This is outside the scope of this PR but worth noting for a future cleanup pass.
  • Pre-existing issue (not introduced by this PR): Several ## headings elsewhere in the file ("Sending Messages", "Formatting Messages", "Using @mention", "From the Members Pane", "Via Link or QR Code") are noun-based rather than task-based, violating Section 2 heading rules. Again, not part of this diff.

Recommendations

  1. Consider adding the feature name to the new headings for stronger AI retrieval, e.g., "How to edit or delete a chat message on web" (adding "chat" ties it to the feature name).
  2. Standardize capitalization of "web" and "mobile" in headings -- either both lowercase or both capitalized -- for internal consistency within the article.
  3. (Future PR) Address pre-existing heading structure violations: collapse the multiple # headings into ## under a single # title, and convert noun-based ## headings to task-based format.

Files Reviewed

  • docs/articles/new-expensify/chat/Chat-Features-and-Moderation-Tools.md -- Platform terminology fix and edit/delete section restructured with proper platform-specific ## headings and added detail. Changes are well-aligned with governance standards.

Review based on governance files: HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md.

3. Select **Edit comment** or **Delete comment**.
4. If editing, update the text inline and press **Enter** to save.

## How to edit or delete a message on mobile
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heading style: Same suggestion as the web counterpart -- consider including the feature name for searchability.

Suggestion: ## How to edit or delete a chat message on mobile

@stephanieelliott stephanieelliott requested a review from a team May 20, 2026 01:30
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 20, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @lschurr

@melvin-bot melvin-bot Bot requested review from lschurr and removed request for a team May 20, 2026 01:31
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 20, 2026

@lschurr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR improves the "Chat Features and Moderation Tools" article by (1) correcting a platform label from "Desktop" to "Web" and (2) splitting the edit/delete message instructions into separate web and mobile sections with platform-specific detail. Both changes align with governance requirements for cross-platform clarity and accurate UI terminology.

Scores Summary

  • Readability: 9/10 - The new platform-split steps are clear, sequential, and action-oriented. Step 4 in each section ("If editing...") smoothly handles the conditional without breaking flow. Minor note: the two sections are very parallel, which aids scannability.
  • AI Readiness: 7/10 - The new ## headings ("How to edit or delete a message on web" / "on mobile") are task-based and searchable, which is good. However, these headings do not include the feature name ("New Expensify Chat" or "Expensify") as recommended by the authoring guidelines (Section 6: "Include at least one full 'How to...' heading using feature name"). Additionally, the existing article still lacks an internalScope field in its YAML metadata (Section 3 requirement), though that is pre-existing and outside the scope of this diff.
  • Style Compliance: 8/10 - The "Desktop" to "Web" rename correctly aligns with naming conventions (the governance files use "web" and "mobile" as platform labels, not "Desktop"). Button names (Edit comment, Delete comment, Enter, Save) are properly bolded. One minor observation: the parent # Edit or Delete Messages heading is not task-based (it is a noun phrase), which conflicts with Section 2 heading rules -- but this heading is pre-existing and unchanged in the diff.

Key Findings

  • Positive: Splitting edit/delete instructions by platform directly follows the Navigation Instruction Standards rule: "If Web and Mobile Navigation Differ, provide separate instructions. Do not merge these into one sentence." This is well executed.
  • Positive: The "Desktop" to "Web" rename fixes a terminology inconsistency. The governance files reference "web" as the correct platform label.
  • Positive: Adding platform-specific behavioral detail (right-click vs. long-press, inline editing vs. composer) gives users accurate, actionable guidance.
  • Minor gap: The new ## headings would be stronger with the feature name included (e.g., "How to edit or delete a chat message on web").

Recommendations

  1. Consider adding the feature name to the new ## headings for better AI retrieval (e.g., "How to edit or delete a message on web in Expensify Chat").
  2. As a follow-up (not blocking this PR), the article would benefit from adding internalScope to the YAML frontmatter and reviewing the existing # headings for task-based compliance.

Files Reviewed

  • docs/articles/new-expensify/chat/Chat-Features-and-Moderation-Tools.md - Two targeted improvements: platform label correction and platform-split edit/delete instructions. Both changes are sound and governance-aligned.

# Edit or Delete Messages

**To edit or delete a message:**
## How to edit or delete a message on web
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming and style: "web" should be capitalized to "Web" for consistency with the rest of the article (e.g., line 19 uses "On Web:") and standard platform naming.

Suggested change
## How to edit or delete a message on web
## How to edit or delete a message on Web

3. Select **Edit comment** or **Delete comment**.
4. If editing, update the text inline and press **Enter** to save.

## How to edit or delete a message on mobile
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming and style: "mobile" should be capitalized to "Mobile" for consistency with the rest of the article (e.g., line 26 uses "On Mobile:") and standard platform naming.

Suggested change
## How to edit or delete a message on mobile
## How to edit or delete a message on Mobile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants